fix: Correct tool existence checks #1145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulecp
force-pushed
the
fix_yamllint_ci
branch
from
7940d28 to
6d990db
Compare
pulecp
changed the title
pulecp
force-pushed
the
fix_yamllint_ci
branch
from
6d990db to
f11ef51
Compare
pulecp
changed the title
`command -v <cmd>` returns a path to a binary to stdout if it's found in PATH. The condition deciding if `<cmd>` is installed redirects stdout to `/dev/null` and so this check could never work. This change redirects stderr to `/dev/null` instead of stdout to compare the output of `command -v <cmd>` properly with an empty string. I unified the redirection to a file in whole file. The empty space behind redirection is not needed. Signed-off-by: Pavel Pulec <[email protected]>
pulecp
force-pushed
the
fix_yamllint_ci
branch
from
f11ef51 to
45466b0
Compare
|
hi @pulecp Makefile.common is managed in https://github.com/prometheus/prometheus repo, and synced here by automation. please make this change in upstream. once merged in prometheus/prometheus, automation will sync it here. |
|
thanks for the PR but I am going to close this PR because we can't merge this change here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
command -v <cmd>returns a path to a binary to stdout if it's found in PATH. The condition deciding if<cmd>is installed redirects stdout to/dev/nulland so this check could never work.This change redirects stderr to
/dev/nullinstead of stdout to compare the output ofcommand -v <cmd>properly with an empty string.I unified the redirection to a file in whole file. The empty space behind redirection is not needed.
Signed-off-by: Pavel Pulec [email protected]