Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: content revamp #62

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

rexagod
Copy link

@rexagod rexagod commented Nov 1, 2023

These changes mostly entail:

  • workflow to check for new theme releases,
  • improved synchronization logic,
  • better reference defintions in generated content,
  • serve minified JS,
  • higher degree of automation.

Fixes: prometheus-operator/prometheus-operator#6046

These changes mostly entail:
* workflow to check for new theme releases,
* improved synchronization logic,
* better reference defintions in generated content,
* serve minified JS,
* higher degree of automation.

Fixes: prometheus-operator/prometheus-operator#6046

Signed-off-by: Pranshu Srivastava <[email protected]>
@rexagod
Copy link
Author

rexagod commented Nov 1, 2023

I'd like to propose a standard that all documentation in the dependent repositories adhere to, in order to improve the overall readability of the website. A couple of concerns I noticed were:

  • Missing header sections, which will cause Hugo to crash, if they are hyperlinked within the served manifests. Currently the script prepends a title: XXXX (foo-bar.md becomes ---\ntitle: Foo Bar\n---\n) to documents lacking such a header section.
  • HTML and short-code are used interchangeably for inserting web elements into the documents, and there seems to be no clear choice between the two.
  • Redundant prepended path in links (bar.md is specified as foo/bar.md, when the former would work just the same). Introducing a lint rule for this would ensure the path translation of the pages w.r.t. serving content (content/docs/foo/bar.md is served as localhost:XXXX/docs/foo/bar/ and needs to be sed-ed as such before serving) is consistent throughout the text.

These are the ones I can think of right now from the top of my mind, but in general, it could prove beneficial to adhere to a documentation standard (such as k/enhancements does for KEPs) and even introducing a lint rule to automate validating all that.

@rexagod
Copy link
Author

rexagod commented Nov 2, 2023

@simonpasquier raised a concern around outdated content that we'd be better off ignoring when compiling the website. I believe this could be addressed when writing the document and including something like website-ignore: true within the header.

@simonpasquier
Copy link
Contributor

Thanks for starting this! From my POV, I'd like first that we clean up the existing MarkDown files (in terms of consistency, relevance, out-dated information, ....) as well as brainstorm on how we want the content to be organized.

@rexagod
Copy link
Author

rexagod commented Nov 2, 2023

Sounds good, Simon. I'll get started on that front. :)

@simonpasquier
Copy link
Contributor

Having said that, some of the proposed changes might already be good to go (like Makefile updates).

@slashpai
Copy link
Contributor

@AshwinSriram11 since you are already working on website see if this helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting 404 while accessing Ingress Guide
3 participants