[feat] - Add MonitoringOverlapping #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heliapb
changed the title
heliapb
force-pushed
the
feat/analyzeselectors
branch
from
b71de06 to
07b44c0
Compare
Signed-off-by: Hélia Barroso <[email protected]>
heliapb
force-pushed
the
feat/analyzeselectors
branch
from
21f0624 to
1778e9c
Compare
Signed-off-by: Hélia Barroso <[email protected]>
| podOverlaps := make(map[string][]string) | ||
| var overlapErrs []string | ||
|
|
||
| for _, servicemonitor := range serviceMonitors.Items { |
Collaborator
There was a problem hiding this comment.
I don't think it's required for a first version, but would be nice if we can also compare pod monitors with service monitors.
Imagine a use case where you deploy one pod monitor and one service monitor to collect metrics from the same service.
Signed-off-by: Hélia Barroso <[email protected]>
Signed-off-by: Hélia Barroso <[email protected]>
internal/analyzers/overlapping.go
Outdated
| } | ||
| } | ||
|
|
||
| for key, pdMonitors := range podOverlaps { |
Collaborator
There was a problem hiding this comment.
If we properly build the error message inside each for we don't nee to iterate it again to rebuild the error mesage, wdyt?
Member
Author
There was a problem hiding this comment.
Hi, mv the error inside the overlapping function, wdyt?
Signed-off-by: Hélia Barroso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From issue #47