Merge pull request #1111 from Luis-TT/fix-windows-addon-label

prometheus-operator · Apr 27, 2021 · 984de5f · 984de5f
2 parents 9d69c4c + 419eaf2
commit 984de5f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/examples/windows.jsonnet b/examples/windows.jsonnet
@@ -7,9 +7,9 @@ local kp =
         namespace: 'monitoring',
       },
       windowsScrapeConfig+:: {
-        static_configs: {
+        static_configs: [{
           targets: ['10.240.0.65:5000', '10.240.0.63:5000'],
-        },
+        }],
       },
     },
   };

diff --git a/jsonnet/kube-prometheus/addons/windows.libsonnet b/jsonnet/kube-prometheus/addons/windows.libsonnet
@@ -3,6 +3,7 @@ local windowsrules = import 'kubernetes-mixin/rules/windows.libsonnet';
 
 {
   values+:: {
+    // This needs to follow prometheus naming convention and not prometheus-operator one
     windowsScrapeConfig+:: {
       job_name: 'windows-exporter',
       static_configs: [
@@ -15,10 +16,10 @@ local windowsrules = import 'kubernetes-mixin/rules/windows.libsonnet';
           action: 'replace',
           regex: '(.*)',
           replacement: '$1',
-          sourceLabels: [
+          source_labels: [
             '__meta_kubernetes_endpoint_address_target_name',
           ],
-          targetLabel: 'instance',
+          target_label: 'instance',
         },
       ],
     },