Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'needs' from workflows with only one job #1598

Closed
wants to merge 1 commit into from
Closed

Remove 'needs' from workflows with only one job #1598

wants to merge 1 commit into from

Conversation

cristiangreco
Copy link
Contributor

When there's only one job, it must have no dependencies.

@cristiangreco
Remove 'needs' from workflows with only one job
5c28fb5 
When there's only one job, it must have no dependencies.

Signed-off-by: Cristian Greco <[email protected]>
@cristiangreco cristiangreco requested a review from SuperQ December 19, 2024 16:44
@cristiangreco cristiangreco mentioned this pull request Dec 19, 2024
Merged
SuperQ
SuperQ reviewed Dec 28, 2024
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we actually need to combine the push/release workflows into the ci.yaml workflow since the needs is necessary. The standard publish pipeline uses artifacts from the build stage for efficiency.

@SuperQ
Copy link
Contributor

SuperQ commented Dec 28, 2024

See: #1599

@cristiangreco
Copy link
Contributor Author

Closing in favour of #1599

@cristiangreco cristiangreco deleted the cristian/fix-workflow-push-release branch December 30, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristiangreco @SuperQ