-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-discovery for Directory Services(MicrosoftAD) #757 #1556
base: master
Are you sure you want to change the base?
Add auto-discovery for Directory Services(MicrosoftAD) #757 #1556
Conversation
bec657b
to
4becfcd
Compare
133d7cd
to
f835fdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Do you mind adding a test like pkg/job/maxdimassociator/associator_api_gateway_test.go
?
Sure, will take some time. |
32599b7
to
cc4a7d1
Compare
@@ -0,0 +1,61 @@ | |||
package maxdimassociator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RuslanMustaev sorry the license check is failing, could you please add the header to this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Ruslan Mustaev <[email protected]>
b6dd355
to
d287301
Compare
For the feature request #757