Set outbound interface, like `ping -I` option #32

ilolicon · 2023-04-12T03:01:16Z

Hello,

I attempted to implement a useful feature - sending data packets from a specific network interface, similar to what the "ping" command's "-I" option does in Linux.
Hoping I did it correctly. Test successfully passed on Linux OS.

Thanks!

The issues related to this feature:

go-ping/ping#111

go-ping/ping#204

SuperQ · 2023-04-12T05:39:30Z

This needs a DCO sign-off. You can use git commit -s --amend to add it.

Hipska · 2023-04-12T07:25:41Z

ping.go

+	// Iface used to send/recv ICMP messages
+	Iface string


I don't like the short name

Suggested change

// Iface used to send/recv ICMP messages

Iface string

// Interface used to send/recv ICMP messages

Interface string

The original intention was just to avoid confusion with the go interface keyword

Maybe InterfaceName then if needed?

I adopted Interface to make a new commit but the ci test still fails
I use the same ci docker image locally and it works fine. Am I doing something wrong?
I hope you can give me some help, thank you very much

circleci@3b386f984da0:~/project/pro-bing$ git branch -vv * feature-interface-binding 60b7449 [origin/feature-interface-binding] Refactoring the variable name `Iface` to `Interface` and `ifaceIndex` to `ifIndex`(keeping it consistent with `ControlMessage`) main a17ba03 [origin/main] Merge pull request #29 from TheRushingWookie/add_context circleci@3b386f984da0:~/project/pro-bing$ make style vet test >> checking code style >> vetting code GO111MODULE= go vet ./... >> running all tests GO111MODULE= go test -race -cover ./... ok github.com/prometheus-community/pro-bing (cached) coverage: 76.9% of statements ? github.com/prometheus-community/pro-bing/cmd/ping [no test files]

ci error message: socket: permission denied

Signed-off-by: ilolicon <[email protected]>

… to `ifIndex`(keeping it consistent with `ControlMessage`) Signed-off-by: ilolicon <[email protected]>

ja-he · 2023-05-04T08:56:44Z

cmd/ping/ping.go

@@ -29,6 +29,9 @@ Examples:
    # ping google for 10 seconds
    ping -t 10s www.google.com

+    # ping google specified interface
+    ping -I eth1 www.goole.com


there is a typo here: goo[g]le.com

Suggested change

ping -I eth1 www.goole.com

ping -I eth1 www.google.com

bluecmd · 2023-11-10T18:13:43Z

FWIW, I would like to see this feature added in order to use VRF with this library.

HsimWong · 2024-07-19T03:24:58Z

I need this feature really bad. Can anyone merge this?

bluecmd · 2024-07-19T07:10:36Z

The PR needs to be rebased if it is to have any chance of getting merged.

dan-sherwin · 2024-09-27T02:06:10Z

Checking on this PR? I could use it. Is it dead?

liuweiky · 2024-10-18T08:07:54Z

Hi, any updates on this PR? It is quite useful when debugging the network on hosts with multiple net interfaces.

MatthieuCoder · 2024-10-29T11:19:39Z

I need this to use link-local IPv6 addresses

Hipska · 2024-10-29T11:21:46Z

At least the PR has conflicts, @ilolicon can you resolve them?

SuperQ · 2024-10-29T11:23:53Z

If someone would like to fork this code and submit a new PR, feel free.

@ilolicon

This allows using `pro-bing` to use VRFs interfaces and IPv6 link-local addresses. Originally from @ilolicon in prometheus-community#32. commit 16f9286 Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 15:46:13 2024 +0400 Remove the un-used function in te `packetConn` interface that did not get removed during the merging process commit 88bb1f5 Author: ilolicon <[email protected]> Date: Wed Apr 12 16:23:06 2023 +0800 Refactoring the variable name `Iface` to `Interface` and `ifaceIndex` to `ifIndex`(keeping it consistent with `ControlMessage`) Signed-off-by: ilolicon <[email protected]> commit 887b4e2 Author: ilolicon <[email protected]> Date: Wed Apr 12 10:39:36 2023 +0800 feat: interface binding Signed-off-by: ilolicon <[email protected]>

@ilolicon

This allows using `pro-bing` to use VRFs interfaces and IPv6 link-local addresses. Originally from @ilolicon in prometheus-community#32. commit 16f9286 Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 15:46:13 2024 +0400 Remove the un-used function in te `packetConn` interface that did not get removed during the merging process commit 88bb1f5 Author: ilolicon <[email protected]> Date: Wed Apr 12 16:23:06 2023 +0800 Refactoring the variable name `Iface` to `Interface` and `ifaceIndex` to `ifIndex`(keeping it consistent with `ControlMessage`) Signed-off-by: ilolicon <[email protected]> commit 887b4e2 Author: ilolicon <[email protected]> Date: Wed Apr 12 10:39:36 2023 +0800 feat: interface binding Signed-off-by: ilolicon <[email protected]> Signed-off-by: Matthieu Pignolet <[email protected]>

@ilolicon

…al addresses. Squashed commit of the following: commit 7385672 Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 16:11:33 2024 +0400 Renaming the `Interface` Pinger property to `InterfaceDevice` to avoid conflict with the `interface` keyword. Signed-off-by: Matthieu Pignolet <[email protected]> commit 978c60e Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 15:59:36 2024 +0400 Add the `Interface` option to `Pinger` This allows using `pro-bing` to use VRFs interfaces and IPv6 link-local addresses. Originally from @ilolicon in prometheus-community#32. commit 16f9286 Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 15:46:13 2024 +0400 Remove the un-used function in te `packetConn` interface that did not get removed during the merging process commit 88bb1f5 Author: ilolicon <[email protected]> Date: Wed Apr 12 16:23:06 2023 +0800 Refactoring the variable name `Iface` to `Interface` and `ifaceIndex` to `ifIndex`(keeping it consistent with `ControlMessage`) Signed-off-by: ilolicon <[email protected]> commit 887b4e2 Author: ilolicon <[email protected]> Date: Wed Apr 12 10:39:36 2023 +0800 feat: interface binding Signed-off-by: ilolicon <[email protected]> Signed-off-by: Matthieu Pignolet <[email protected]>

@ilolicon

…al addresses. Squashed commit of the following: commit 7385672 Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 16:11:33 2024 +0400 Renaming the `Interface` Pinger property to `InterfaceDevice` to avoid conflict with the `interface` keyword. Signed-off-by: Matthieu Pignolet <[email protected]> commit 978c60e Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 15:59:36 2024 +0400 Add the `Interface` option to `Pinger` This allows using `pro-bing` to use VRFs interfaces and IPv6 link-local addresses. Originally from @ilolicon in prometheus-community#32. commit 16f9286 Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 15:46:13 2024 +0400 Remove the un-used function in te `packetConn` interface that did not get removed during the merging process commit 88bb1f5 Author: ilolicon <[email protected]> Date: Wed Apr 12 16:23:06 2023 +0800 Refactoring the variable name `Iface` to `Interface` and `ifaceIndex` to `ifIndex`(keeping it consistent with `ControlMessage`) Signed-off-by: ilolicon <[email protected]> commit 887b4e2 Author: ilolicon <[email protected]> Date: Wed Apr 12 10:39:36 2023 +0800 feat: interface binding Signed-off-by: ilolicon <[email protected]> Signed-off-by: Matthieu Pignolet <[email protected]> Signed-off-by: Matthieu Pignolet <[email protected]>

@ilolicon

commit 75cbb26 Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 20:49:25 2024 +0400 Use the machine executor for CI Signed-off-by: Matthieu Pignolet <[email protected]> commit a0e098a Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 20:48:33 2024 +0400 Using the machine executor for CI Signed-off-by: Matthieu Pignolet <[email protected]> commit 77e1065 Merge: 3cb9e40 a563de4 Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 20:09:52 2024 +0400 Merge branch 'prometheus-community:main' into main commit 3cb9e40 Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 20:05:12 2024 +0400 Remote the un-used workaround used to avoid the `lo` interfaces Signed-off-by: Matthieu Pignolet <[email protected]> commit 006d173 Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 17:11:14 2024 +0400 add a function (`testSetInterfaceNameChooseInterface`) to choose any interface that has an IP address assigned to it this is a "hack" to supposedly make CircleCI happy Signed-off-by: Matthieu Pignolet <[email protected]> commit 7385672 Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 16:11:33 2024 +0400 Renaming the `Interface` Pinger property to `InterfaceDevice` to avoid conflict with the `interface` keyword. Signed-off-by: Matthieu Pignolet <[email protected]> commit 978c60e Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 15:59:36 2024 +0400 Add the `Interface` option to `Pinger` This allows using `pro-bing` to use VRFs interfaces and IPv6 link-local addresses. Originally from @ilolicon in prometheus-community#32. commit 16f9286 Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 15:46:13 2024 +0400 Remove the un-used function in te `packetConn` interface that did not get removed during the merging process commit 88bb1f5 Author: ilolicon <[email protected]> Date: Wed Apr 12 16:23:06 2023 +0800 Refactoring the variable name `Iface` to `Interface` and `ifaceIndex` to `ifIndex`(keeping it consistent with `ControlMessage`) Signed-off-by: ilolicon <[email protected]> commit 887b4e2 Author: ilolicon <[email protected]> Date: Wed Apr 12 10:39:36 2023 +0800 feat: interface binding Signed-off-by: ilolicon <[email protected]> Signed-off-by: Matthieu Pignolet <[email protected]> Signed-off-by: Matthieu Pignolet <[email protected]>

@ilolicon

…t specifies the device that needs to be used to send and receive ICMP echo requests and response. This allows usage of `pro-bing` with linux VRFs, and IPv6 link-local addresses. Squashed commit of the following: commit 7385672 Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 16:11:33 2024 +0400 Renaming the `Interface` Pinger property to `InterfaceDevice` to avoid conflict with the `interface` keyword. Signed-off-by: Matthieu Pignolet <[email protected]> commit 978c60e Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 15:59:36 2024 +0400 Add the `Interface` option to `Pinger` This allows using `pro-bing` to use VRFs interfaces and IPv6 link-local addresses. Originally from @ilolicon in prometheus-community#32. commit 16f9286 Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 15:46:13 2024 +0400 Remove the un-used function in te `packetConn` interface that did not get removed during the merging process commit 88bb1f5 Author: ilolicon <[email protected]> Date: Wed Apr 12 16:23:06 2023 +0800 Refactoring the variable name `Iface` to `Interface` and `ifaceIndex` to `ifIndex`(keeping it consistent with `ControlMessage`) Signed-off-by: ilolicon <[email protected]> commit 887b4e2 Author: ilolicon <[email protected]> Date: Wed Apr 12 10:39:36 2023 +0800 feat: interface binding Signed-off-by: ilolicon <[email protected]>

@ilolicon

…t specifies the device that needs to be used to send and receive ICMP echo requests and response. This allows usage of `pro-bing` with linux VRFs, and IPv6 link-local addresses. Squashed commit of the following: commit 7385672 Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 16:11:33 2024 +0400 Renaming the `Interface` Pinger property to `InterfaceDevice` to avoid conflict with the `interface` keyword. Signed-off-by: Matthieu Pignolet <[email protected]> commit 978c60e Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 15:59:36 2024 +0400 Add the `Interface` option to `Pinger` This allows using `pro-bing` to use VRFs interfaces and IPv6 link-local addresses. Originally from @ilolicon in prometheus-community#32. commit 16f9286 Author: Matthieu Pignolet <[email protected]> Date: Tue Oct 29 15:46:13 2024 +0400 Remove the un-used function in te `packetConn` interface that did not get removed during the merging process commit 88bb1f5 Author: ilolicon <[email protected]> Date: Wed Apr 12 16:23:06 2023 +0800 Refactoring the variable name `Iface` to `Interface` and `ifaceIndex` to `ifIndex`(keeping it consistent with `ControlMessage`) Signed-off-by: ilolicon <[email protected]> commit 887b4e2 Author: ilolicon <[email protected]> Date: Wed Apr 12 10:39:36 2023 +0800 feat: interface binding Signed-off-by: ilolicon <[email protected]> Signed-off-by: Matthieu Pignolet <[email protected]>

ilolicon · 2024-10-30T10:22:51Z

At least the PR has conflicts, @ilolicon can you resolve them?

Sorry, I was too busy recently and didn't pay attention to the news. It seems that @MatthieuCoder has resolved the conflict.

HsimWong · 2024-11-05T09:34:24Z

Resolved #123

ilolicon changed the title ~~Set outbound interface name, like ping -I option~~ Set outbound interface, like ping -I option Apr 12, 2023

Hipska reviewed Apr 12, 2023

View reviewed changes

ilolicon added 2 commits April 12, 2023 16:28

feat: interface binding

d55df2c

Signed-off-by: ilolicon <[email protected]>

Refactoring the variable name Iface to Interface and ifaceIndex…

60b7449

… to `ifIndex`(keeping it consistent with `ControlMessage`) Signed-off-by: ilolicon <[email protected]>

ilolicon force-pushed the feature-interface-binding branch from 8dffa7b to 60b7449 Compare April 12, 2023 08:29

Hipska approved these changes Apr 12, 2023

View reviewed changes

ilolicon requested a review from Hipska April 15, 2023 07:55

Hipska approved these changes Apr 17, 2023

View reviewed changes

ja-he reviewed May 4, 2023

View reviewed changes

MatthieuCoder mentioned this pull request Oct 29, 2024

Add the InterfaceName option to Pinger #123

Merged

SuperQ closed this Nov 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set outbound interface, like `ping -I` option #32

Set outbound interface, like `ping -I` option #32

ilolicon commented Apr 12, 2023

SuperQ commented Apr 12, 2023

Hipska Apr 12, 2023

ilolicon Apr 12, 2023

Hipska Apr 12, 2023

ilolicon Apr 12, 2023 •

edited

Loading

ja-he May 4, 2023

Hipska Jul 19, 2024

bluecmd commented Nov 10, 2023

HsimWong commented Jul 19, 2024

bluecmd commented Jul 19, 2024

dan-sherwin commented Sep 27, 2024

liuweiky commented Oct 18, 2024

MatthieuCoder commented Oct 29, 2024

Hipska commented Oct 29, 2024

SuperQ commented Oct 29, 2024

ilolicon commented Oct 30, 2024

HsimWong commented Nov 5, 2024

Set outbound interface, like ping -I option #32

Set outbound interface, like ping -I option #32

Conversation

ilolicon commented Apr 12, 2023

SuperQ commented Apr 12, 2023

Hipska Apr 12, 2023

Choose a reason for hiding this comment

ilolicon Apr 12, 2023

Choose a reason for hiding this comment

Hipska Apr 12, 2023

Choose a reason for hiding this comment

ilolicon Apr 12, 2023 • edited Loading

Choose a reason for hiding this comment

ja-he May 4, 2023

Choose a reason for hiding this comment

Hipska Jul 19, 2024

Choose a reason for hiding this comment

bluecmd commented Nov 10, 2023

HsimWong commented Jul 19, 2024

bluecmd commented Jul 19, 2024

dan-sherwin commented Sep 27, 2024

liuweiky commented Oct 18, 2024

MatthieuCoder commented Oct 29, 2024

Hipska commented Oct 29, 2024

SuperQ commented Oct 29, 2024

ilolicon commented Oct 30, 2024

HsimWong commented Nov 5, 2024

Set outbound interface, like `ping -I` option #32

Set outbound interface, like `ping -I` option #32

ilolicon Apr 12, 2023 •

edited

Loading