docs(mixin): go get -> go install#928
Open
clouedoc wants to merge 1 commit intoprometheus-community:masterfrom
Open
docs(mixin): go get -> go install#928clouedoc wants to merge 1 commit intoprometheus-community:masterfrom
clouedoc wants to merge 1 commit intoprometheus-community:masterfrom
Conversation
> Starting in Go 1.17, installing executables with go get is deprecated. go install may be used instead. > > In Go 1.18, go get will no longer build packages; it will only be used to add, update, or remove dependencies in go.mod. Specifically, go get will always act as if the -d flag were enabled. More information: https://go.dev/doc/go-get-install-deprecation Signed-off-by: Camille Louédoc-Eyriès <clouedoc@tutanota.com>
SuperQ
requested changes
Oct 27, 2023
Comment on lines
+14
to
+15
| $ go install github.com/monitoring-mixins/mixtool/cmd/mixtool | ||
| $ go install github.com/google/go-jsonnet/cmd/jsonnetfmt |
Contributor
There was a problem hiding this comment.
You need to specify a version.
Suggested change
| $ go install github.com/monitoring-mixins/mixtool/cmd/mixtool | |
| $ go install github.com/google/go-jsonnet/cmd/jsonnetfmt | |
| $ go install github.com/monitoring-mixins/mixtool/cmd/mixtool@latest | |
| $ go install github.com/google/go-jsonnet/cmd/jsonnetfmt@latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More information: https://go.dev/doc/go-get-install-deprecation