Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openpgp: implement WKD advanced lookup #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

robbat2
Copy link
Contributor

@robbat2 robbat2 commented Feb 6, 2023

Signed-off-by: Robin H. Johnson [email protected]

@robbat2
Copy link
Contributor Author

robbat2 commented Feb 6, 2023

It's not perfect yet, I couldn't figure out how how to mock socket.getaddrinfo for testing

@mgorny
Copy link
Member

mgorny commented Feb 15, 2023

My first concern is that this bypasses proxy.

@robbat2
Copy link
Contributor Author

robbat2 commented Feb 16, 2023

Hmm, the spec does say to do the advanced/direct switch depending if the hostname exists.
How do we make that determination behind a proxy? Do we trust that the HTTPS request via the proxy returns a meaningful 404 vs actual data?

tests/test_openpgp.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants