fix(Color): don't use shared global state (Color.BG etc.)
#363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmillr
force-pushed
the
fix-color-global-state
branch
2 times, most recently
from
ff121e8
to
e1ed985
Compare
tmillr
force-pushed
the
fix-color-global-state
branch
7 times, most recently
from
e749c06
to
fbd3544
Compare
tmillr
changed the title
Color.BG etc.)
tmillr
force-pushed
the
fix-color-global-state
branch
from
fbd3544
to
d3e28a2
Compare
Fix bug where the colorscheme colors are off/incorrect when a palette is require()'d, whether directly or indirectly, anytime before compilation occurs (e.g. compilation that occurs during colorscheme load). For details, see issue projekt0n#362. Also, add a test (in `test/`) which disallows the direct or indirect use of the global static/class fields of the `Color` class (e.g. `Color.BG`). Fixes: projekt0n#362
tmillr
force-pushed
the
fix-color-global-state
branch
from
d3e28a2
to
0a358a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where the colorscheme colors are off/incorrect when a palette is
require()'d, whether directly or indirectly, anytime before compilation occurs (e.g. compilation that occurs during colorscheme load). For details, see issue #362.Also, add a test (in
test/) which disallows the direct or indirect use of the global static/class fields of theColorclass (e.g.Color.BG).Fixes: #362