Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter to CI #104

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add linter to CI #104

wants to merge 10 commits into from

Conversation

timimsms
Copy link
Contributor

Adds step to CircleCI configuration to run our linter.

Description

Sets up ESLint to run as part of our CircleCI/CI configuration and build pipeline.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • The console is clean. No errors or linting warnings

@timimsms timimsms self-assigned this Apr 17, 2020
@timimsms timimsms force-pushed the chore/add-linter-to-circleci branch from cd35a9d to 849ce2b Compare April 18, 2020 02:16
@timimsms timimsms linked an issue Apr 18, 2020 that may be closed by this pull request
Attempts to manually handle the steps of installing and running eslint without the use of the recommended CircleCI orb.
Adds details to README around usage of Node/NPM, as well as version tracking for out-of-repo dependencies.
May have been introduced by recent package updates; but not sure if this was just introduced in an earlier update.
Ensures build and snapshot directories (and contents) are fully ignored.
@timimsms timimsms force-pushed the chore/add-linter-to-circleci branch from 4b8d0f9 to b761e02 Compare April 29, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter Not Running in CircleCI
1 participant