Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter Not Running in CircleCI #105

Open
timimsms opened this issue Apr 18, 2020 · 1 comment · May be fixed by #104
Open

Linter Not Running in CircleCI #105

timimsms opened this issue Apr 18, 2020 · 1 comment · May be fixed by #104
Assignees
@timimsms

Comments

@timimsms
Copy link
Contributor

timimsms commented Apr 18, 2020 •
edited
Loading

Issue Overview

What are you trying to do?

Have consistent code style checks on new code added to repository via pull requests.

What did you expect to happen?

Run ESLint on CircleCI without any errors.

What actually happened?

Failing to run on CircleCI
Seeing a number of errors locally

Steps to Reproduce

  1. Latest build attempt can be re-run here: https://app.circleci.com/pipelines/github/projectunic0rn/travel-map-ui/324/workflows/8d024ca2-1c0f-4940-b35b-da8e60727f10/jobs/327
  2. Can checkout this branch and run eslint .

Issue Details

Attached is a file with the current linter issues I'm seeing when running locally.

We may also need to get permission to use CircleCI Orbs within projectunic0rn as that seems like a more straight-forward option to running ESLint on CircleCI consistently.

Additionally, there is a chance that we are not actually "clean" with out code/linter, as it seems there may have been some inconsistencies in how this was setup/it has not been running on PR's for some time/may never have fully worked.

Not urgent, but definitely something we should address.
@timimsms timimsms self-assigned this Apr 18, 2020
@timimsms timimsms linked a pull request Apr 18, 2020 that will close this issue
Add linter to CI #104
Open
4 tasks
@timimsms
Copy link
Contributor Author

@GreenWithMV let's look to touch base sometime next week on this as I imagine it's a bit of updating the config to better match your local environment/configuration as I know you mentioned you have not been seeing linter issues when running the project on your end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timimsms timimsms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add linter to CI projectunic0rn/travel-map-ui
1 participant
@timimsms