Add logic to generate Renovate postUpgradeTasks in the component template
#424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modulesync template (https://github.com/projectsyn/modulesync-control), doesn't use the `githubUrl` parameter anymore. This commit removes the parameter from the initial modulesync config generated by `commodore component new`.
3 tasks
simu
changed the title
postUpgradeTasks in component templatepostUpgradeTasks in the component template
simu
force-pushed
the
feat/component-template/renovate-postupgrade-tasks
branch
from
7b70ceb to
80ee3e7
Compare
simu
force-pushed
the
feat/component-template/renovate-postupgrade-tasks
branch
from
80ee3e7 to
fa1ade5
Compare
…template These targets are written to use a static list of test instances in make variable `test_instances`. Since the initial template only has a single test instance, we just hard code the default value of the variable in the component template. We use a generic recursive make target based on the `test_instances` make variable to implement the new targets. This allows us to reuse the existing `golden-diff` and `gen-golden` targets. The new targets are only added for components which have matrix tests enabled (command line flag `--matrix-tests`).
This commit adds logic to the `renovate.json` template in the component template to generate section `postUpgradeTasks` when golden tests are enabled when creating a component with `commodore component new`.
This commit adjusts the initial modulesync config generated by the component template to match the changes introduced by projectsyn/modulesync-control#62 which facilitate keeping the Renovate `postUpgradeTasks` updated when new matrix tests are added.
simu
force-pushed
the
feat/component-template/renovate-postupgrade-tasks
branch
from
fa1ade5 to
1903a2d
Compare
bastjan
approved these changes
Mar 21, 2022
glrf
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains the following changes:
githubUrlfrom the initial modulesync config in the component template.golden-diff-allandgen-golden-allin the component templaterenovate.jsontemplate in the component template to generate sectionpostUpgradeTaskswhen golden tests are enabled when creating a component withcommodore component new.Add logic to generate Renovate
postUpgradeTasksmodulesync-control#62 which facilitate keeping the RenovatepostUpgradeTasksupdated when new matrix tests are added.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog