Fix fileMatch for commodore-helm manager
#388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
fix/commodore-helm-file-pattern
branch
from
f728ab8 to
3e47583
Compare
We need to anchor the beginning of the `fileMatch` commodore-helm regex `class/[^.].ya?ml$` so that we don't accidentally match any files in golden tests whose name or path contains the fragment `class/`, such as component-rook-ceph's `rbd-extra-storageclass` test case. Unfortunately, writing a test for this is tricky because we're configuring Renovate internals which we can't easily exercise in our test cases.
simu
force-pushed
the
fix/commodore-helm-file-pattern
branch
2 times, most recently
from
517b5f8 to
7140e08
Compare
simu
force-pushed
the
fix/commodore-helm-file-pattern
branch
from
7140e08 to
234bdb4
Compare
haasad
approved these changes
Jan 31, 2025
bastjan
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to anchor the beginning of the
fileMatchcommodore-helm regexclass/[^.].ya?ml$so that we don't accidentally match any files in golden tests whose name or path contains the fragmentclass/, such as component-rook-ceph'srbd-extra-storageclasstest case.Added a test case which tests the
fileMatchregex pattern against some representative cases.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog