(bug) WithValidateHealths and WithPreDeployChecks in prepareSetters.#1817
Merged
Merged
Conversation
Problem: Both options were conditioned on clusterSummary being deleted, which is the wrong signal. A ClusterSummary can have a zero deletion timestamp while still removing a specific helm chart (e.g. chart removed from a ClusterProfile that still manages other charts). In that scenario, WithValidateHealths would be included during a pure undeploy, and WithPreDeployChecks was unconditionally included regardless of whether anything was being deployed.
gianlucam76
force-pushed
the
gate-health-checks
branch
from
38539d5 to
c730fbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Both options were conditioned on clusterSummary being deleted, which is the wrong signal. A ClusterSummary can have a zero deletion timestamp while still removing a specific helm chart (e.g. chart removed from a ClusterProfile that still manages other charts). In that scenario, WithValidateHealths would be included during a pure undeploy, and WithPreDeployChecks was unconditionally included regardless of whether anything was being deployed.