-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize PropertyLayer #2440
base: main
Are you sure you want to change the base?
Stabilize PropertyLayer #2440
Conversation
Removes the warning that the PropertyLayer is experimental, and thus stabilize it. It has been used in example models, integrated into the visualisation (both standalone and as part of the cell space) and in Mesa for almost a year without needing API changes. Note that while the PropertyLayer itself is stable, not all it's integration might be, like the integration into the still experimental cell space.
This comment was marked as off-topic.
This comment was marked as off-topic.
We need to resolve the coordinate system discussion raised in #2431 as part of the stabilization. |
What would minimally be done to declare the current functionality stable? (CC @wang-boyu) |
Resolve #2431. Thinking about this a bit more and looking at the code, I would also move the property layer classes into their own |
Yeah I was also thinking of splitting it out. We could do |
I suggest underpromising by calling it |
That's why I was considering a more general name instead of a specific file for one single class. |
In my view it would be PropertyLayer and HasPropertyLayers (a refactor of _PropertyGrid that can also be used with newstyle discrete spaces). |
Just a quick remark: at the moment, property layers throw user warnings based on the dtype stuff. Its not possible to get rid of those, because of the hardcoded |
Removes the warning that the PropertyLayer is experimental, and thus stabilize it.
It has been used in example models (projectmesa/mesa-examples#214), integrated in the cell space (#2319) and the visualisation (both standalone (#2336) and as part of cell spaces (#2430)) and in Mesa for almost a year (#1898) without needing API changes.
Note that while the PropertyLayer itself is stable, not all it's integrations might be, like the integration into the still experimental cell space.