Skip to content

Support Jackson3 in @Jacksonized #3960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Support Jackson3 in @Jacksonized #3960

wants to merge 11 commits into from
+185 −28

Conversation

cachescrubber
Copy link

Resolves #3950

  • Deals with Jackson annotations in the source that just have to be copied (HandlerUtil.java)

  • Uses a new config option, lombok.jacksonized.jacksonVersion to decide which version of JsonDeserialize and JsonPOJOBuilder to use.

janrieke
janrieke suggested changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@janrieke janrieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor remarks on the code style.

janrieke
janrieke approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@janrieke janrieke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. :)

As this seems to be your first lombok contribution, you have to add yourself to the AUTHORS file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@janrieke janrieke janrieke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Support Jackson3 in @Jacksonized

2 participants

@cachescrubber @janrieke