Skip to content

Conversation

lbenedetto
Copy link

@lbenedetto lbenedetto commented Jul 24, 2025

I am seeking early feedback before I put in more time on this. Am I doing this right? I've never touched code like this before and I feel pretty lost.

TODO:

  • Eclipse variant
  • Critical examination of copyable annotations (It would be helpful if you could specify what criteria I should use to filter down the existing list of copyable annotations. I don't understand exactly why we can't just re-use that list)

Questions:

  • Consider better naming. Based on the discussion in the issue, these could perhaps be called "liftableAnnotations" since they are being lifted up from the Delegate to the parent class.
  • Is string comparison good enough (The existing code uses simple string comparison to check for recursive Delegate), or do I need to do something more advanced like JavacHandlerUtil::typeMatches?
  • Am I getting the annotations correctly, or do I need to do something more advanced like JavacHandlerUtil::findCopyableAnnotations?
  • Any other advice you'd like to give me.

This is for this issue:
#603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant