chore(deps): upgrade momentjs #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czosel
force-pushed
the
upgrade-moment
branch
2 times, most recently
from
7057328 to
ba025b9
Compare
The issue that made us downgrade moment has been fixed in ember-moment-shim 3.8.0. adopted-ember-addons/ember-pikaday#343
|
I needed to change the cache keys to make CI pass since there seems to be no way to clear the yarn cache. I'd be ok with merging it like this, next time we need to reset the keys we can revert them. |
Yelinz
approved these changes
Apr 6, 2021
|
🎉 This PR is included in version 7.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue that made us downgrade moment has been fixed in
ember-moment-shim 3.8.0.
adopted-ember-addons/ember-pikaday#343