Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to github.com/mtrmac/gpgme v0.1.2 #369

Open
wants to merge 2 commits into
base: docker-1.13.1-rhel
Choose a base branch
from
Open

Update to github.com/mtrmac/gpgme v0.1.2 #369

wants to merge 2 commits into from

Commits on Feb 20, 2020

  1. Remove vendor/src/github.com/mtrmac/gpgme/ 

    This seems to be a mistaken commit of an intermediate build state
in the old times when vendoring was used via a GOPATH at vendor/src/...

Signed-off-by: Miloslav Trmač <[email protected]>
    @mtrmac
    mtrmac committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    31b404f View commit details
    Browse the repository at this point in the history

  2. Update to github.com/mtrmac/gpgme v0.1.2 

    This fixes CVE-2020-8945 by incorporating
proglottis/gpgme#23 .

Other changes included by the rebase:
- Support for gpgme_off_t (~no-op with the RHEL 7 GPGME 1.3.2)
- Wrapping a few more GPGME functions (irrelevant if we don't call them)
- Better error reporting in Context.GetKey

Given how invasive the CVE fix is (affecting basically all binding
code), it seems safer to just update the package (and be verifiably
equivalent with upstream) than to backport and try to back out the few
other changes.

Performed by updating vendor.conf, and
$ mkdir -p _build/src/github.com/docker
$ ln -s $(pwd) _build/src/github.com/docker/docker
$ GOPATH=$(pwd)/_build:$GOPATH vndr github.com/mtrmac/gpgme

Signed-off-by: Miloslav Trmač <[email protected]>
    @mtrmac
    mtrmac committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    2c7552e View commit details
    Browse the repository at this point in the history