Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectToNetwork is modfying the container but is not locking the o… #344

Open
wants to merge 1 commit into
base: docker-1.13.1-rhel
Choose a base branch
from

Conversation

free2k
Copy link

@free2k free2k commented Jun 13, 2019

ConnectToNetwork` is modfying the container but is not locking the object

Backport of moby#33456

Signed-off-by: wenguangyi [email protected]

- What I did
Panic occasionally when restarting the machine,Log in attachment
docker.log

This issue has been fixed in the docker community

[root@gh-hulk-k8s-node641 ~]# docker version
Client:
Version: 1.13.1
API version: 1.26
Package version: docker-1.13.1-63.mt20190301.git6fe3c2c.el7.centos.x86_64
Go version: go1.7.5
Git commit: 6fe3c2c/1.13.1
Built: Fri Mar 1 06:52:32 2019
OS/Arch: linux/amd64

Server:
Version: 1.13.1
API version: 1.26 (minimum version 1.12)
Package version: docker-1.13.1-63.mt20190301.git6fe3c2c.el7.centos.x86_64
Go version: go1.7.5
Git commit: 6fe3c2c/1.13.1
Built: Fri Mar 1 06:52:32 2019
OS/Arch: linux/amd64
Experimental: false

[root@gh-hulk-k8s-node641 ~]# docker info
Containers: 45
Running: 30
Paused: 0
Stopped: 15
Images: 37
Server Version: 1.13.1
Storage Driver: devicemapper
Pool Name: dockervg-thinpool
Pool Blocksize: 524.3 kB
Base Device Size: 10.74 GB
Backing Filesystem: ext4
Data file:
Metadata file:
Data Space Used: 78.85 GB
Data Space Total: 973.7 GB
Data Space Available: 894.9 GB
Metadata Space Used: 24.78 MB
Metadata Space Total: 10.25 GB
Metadata Space Available: 10.22 GB
Thin Pool Minimum Free Space: 97.37 GB
Udev Sync Supported: true
Deferred Removal Enabled: true
Deferred Deletion Enabled: true
Deferred Deleted Device Count: 0
Library Version: 1.02.140-RHEL7 (2017-05-03)
Logging Driver: json-file
Cgroup Driver: systemd
Plugins:
Volume: local
Network: bridge host macvlan null overlay
Swarm: inactive
Runtimes: runc docker-runc
Default Runtime: docker-runc
Init Binary: /usr/libexec/docker/docker-init-current
containerd version: 6fe3c2cdc915fbfeabb49a14c35fed0849ecca36 (expected: aa8187dbd3b7ad67d8e5e3a15115d3eef43a7ed1)
runc version: e9ab997cfc4151ebcca8e54cf047311121fd4849 (expected: 9df8b306d01f59d3a8029be411de015b7304dd8f)
init version: 5b117de7f824f3d3825737cf09581645abbe35d4 (expected: 949e6facb77383876aeff8a6944dde66b3089574)
Security Options:
seccomp
WARNING: You're not using the default seccomp profile
Profile: /etc/docker/seccomp.json
Kernel Version: 3.10.0-862.mt20190308.130.el7.x86_64
Operating System: CentOS Linux 7 (Core)
OSType: linux
Architecture: x86_64
Number of Docker Hooks: 3
CPUs: 48
Total Memory: 188.6 GiB
Name: gh-hulk-k8s-node641.gh.sankuai.com
ID: KOMP:RLWS:MGOO:XB6X:H5W6:DU4A:GWU7:RHFG:TB6D:3AS6:WDKB:EJ5F
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Experimental: false
Insecure Registries:
127.0.0.0/8
Registry Mirrors:
http://127.0.0.1:65001
registryonline-hulk.sankuai.com
Live Restore Enabled: true
Registries: docker.io (secure)

- How I did it
Backport of moby#33456
- How to verify it
After fixing this problem, try to verify the problem on the tested machine restart, but restarted many times and this problem did not occur, so I think this problem is fixed.
- Description for the changelog
ConnectToNetwork` is modfying the container but is not locking the object
- A picture of a cute animal (not mandatory but encouraged)

@rh-atomic-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@rhatdan
Copy link
Member

rhatdan commented Jun 13, 2019

@free2k What do you need this for?

@free2k
Copy link
Author

free2k commented Jun 16, 2019

@rhatdan Panic occasionally when restarting the machine,Log in attachment
docker.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants