Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default max pid limit #340

Open
wants to merge 1 commit into
base: docker-1.13.1-rhel
Choose a base branch
from

Conversation

haircommander
Copy link

Users were surprised by the suddenly low pid limit on their pods. Change the default to something higher, such as the theoretical maximum number of pids on a 32 bit system.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1696752

Signed-off-by: Peter Hunt [email protected]

Users were surprised by the suddenly low pid limit on their pods. Change the default to something higher, such as the theoretical maximum number of pids on a 32 bit system.

Signed-off-by: Peter Hunt <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Apr 5, 2019

This will allow a couple of pods to cause DOS to other containers on the system. The reason the number was low was to allow lots of containers to run without one container using up all of the pids.

@haircommander
Copy link
Author

@rhatdan @mrunalp what is a good default then? 8196?

@rhatdan
Copy link
Member

rhatdan commented Apr 18, 2019

@haircommander Hard to say.

@haircommander
Copy link
Author

As a user not thinking about this feature, I'd expect my pods to have as many pids as possible. I.E. we should allow them to DOS their system. If they then decide that isn't good, they should change from the default.

@rhatdan
Copy link
Member

rhatdan commented Apr 18, 2019

@haircommander This feature was demanded by our customers, they wanted to make sure that we picked good defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants