This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
dsv: update role to be more consistent across all streams #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost all of the streams are using `overlay2` as the docker storage driver now, so we can remove a lot of the conditional workarounds we had. If we can get CAHC to switch to `overlay2` (see CentOS/sig-atomic-buildscripts#341), we can simplify this role even more.
|
LOL...the
Some chicken and egg stuff here |
mike-nguyen
reviewed
Jun 28, 2018
| fail: | ||
| msg: "The required variables are not defined. Check files under roles/docker_storage_verify/vars" | ||
| - when: ansible_distribution == 'CentOSDev' | ||
| name: Set storage driver for CAHC |
There was a problem hiding this comment.
I know we are trying to put the when statement first stylistically, but i think it makes more sense for the name to go first if there is a name, then the actual code underneath.
There was a problem hiding this comment.
no big deal, i can make that change
|
These are both fairly low risk. I am okay with merging them back to back! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all of the streams are using
overlay2as the docker storagedriver now, so we can remove a lot of the conditional workarounds we
had.
If we can get CAHC to switch to
overlay2(seeCentOS/sig-atomic-buildscripts#341), we can simplify this role even
more.