This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
docker_pull_run_remove: add test for cpu-shares flag #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the `docker_pull_run_remove` role to add a test for the use of `--cpu-shares` flag when doing `docker run`. This is to catch regressions such as RHBZ#1585735. Additionally, I expanded the list of images we are testing to include images from registries other than docker.io. Closes projectatomic#414
|
The |
|
Heh...the Fedora checks might break too, because the new Let's wait on merging this until this update gets included in the stream: https://bodhi.fedoraproject.org/updates/FEDORA-2018-993659ebfd |
|
Sounds good. |
|
@mike-nguyen the |
|
Sounds good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
docker_pull_run_removerole to add a test for theuse of
--cpu-sharesflag when doingdocker run. This is to catchregressions such as RHBZ#1585735.
Additionally, I expanded the list of images we are testing to include
images from registries other than docker.io.
Closes #414