fix: return the entire blob size in patch upload response #3279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this PR ... |
regclient/regclient#961 opencontainers/distribution-spec#581 Previously, zot returned the size of the currently uploaded chunk. Other registries the size of the entire blob. Align with the latter behavior. Signed-off-by: Ramkumar Chinchani <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3279 +/- ##
==========================================
- Coverage 90.58% 90.54% -0.04%
==========================================
Files 183 183
Lines 33001 33003 +2
==========================================
- Hits 29894 29884 -10
- Misses 2340 2349 +9
- Partials 767 770 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andaaron
approved these changes
Jul 30, 2025
|
Maybe add a blackbox test? |
|
Testing against both regctl and the distribution-spec conformance test both LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regclient/regclient#961
opencontainers/distribution-spec#581
Previously, zot returned the size of the currently uploaded chunk. Other registries the size of the entire blob.
Align with the latter behavior.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.