Use final-log for PiG and align-logs #1141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the use of Bifrost live-logs feature for: - PiG (since the final logs will already be present and we should use it for speed and reducing load on bifrost db search) - align-logs (since we don't have a follow mode and we probably will invoke it after the alignment is done)
jomrazek
approved these changes
Apr 22, 2024
|
Oh I might have to keep this open until it's close to final-log release after all. |
|
@jomrazek if 3.0 comes out while I'm out, could you please merge this? It's not a big deal though if it doesn't get merged for 3.0. It can be done later. Thanks! I don't want to merge it too early since people use Snapshot bacon for prod, and the final-log feature is not yet on prod. |
|
Will do, no worries :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the use of Bifrost live-logs feature for:
Checklist: