Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5434] Remove extraneous error message #5327

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Sep 27, 2024

Jira Ticket

COST-5434

Description

An equivalent error is logged in the retry decorator after all retry attempts are exhausted. This is code leftover from the previous behavior and can be removed.

Related to #5210.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Load test customer data.
make create-test-customer
make load-test-customer-data test_source=aws
  1. Delete test customer data
make delete-test-customer-data
  1. Observe retries with no errors in the worker logs.
...
[2024-09-27 20:39:52,118] WARNING 82aaf11b-ac92-46d4-9855-70cd0dd711c9 44415 {'message': 'Retrying... (attempt 1)', 'tracing_id': '', 'exc_info': TrinoHiveMetastoreError()}
[2024-09-27 20:39:52,118: WARNING/MainProcess] {'message': 'Retrying... (attempt 1)', 'tracing_id': '', 'exc_info': TrinoHiveMetastoreError()}
...

Release Notes

  • proposed release note
* [COST-5434](https://issues.redhat.com/browse/COST-5434) Remove extraneous error logging

@samdoran samdoran added the hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix label Sep 27, 2024
@samdoran samdoran requested review from a team as code owners September 27, 2024 20:59
This error message is logged in the retry decorator after all retry attempts
are exhausted. This is code leftover from the previous behavior.
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.0%. Comparing base (ccdfe98) to head (592e92e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5327   +/-   ##
=====================================
  Coverage   94.0%   94.0%           
=====================================
  Files        375     375           
  Lines      31605   31604    -1     
  Branches    4660    4660           
=====================================
  Hits       29716   29716           
  Misses      1207    1207           
+ Partials     682     681    -1     

@samdoran samdoran merged commit dbb6c41 into main Sep 30, 2024
13 of 14 checks passed
@samdoran samdoran deleted the COST-5434/trino-error branch September 30, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants