Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update data_updated_timestamp for polled provider that has no new rep… #5205

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

lcouzens
Copy link
Contributor

@lcouzens lcouzens commented Jul 3, 2024

Jira Ticket

COST-5180

Description

This change will add in an update for data_updated_timestamp for providers that get queued for polling but they have no new reports ready for download yet. This is needed for our new polling logic. For example if we poll a provider and there is no reports we then have to wait 3 days before that provider can be polled again, since we assume that provider has not finished processing.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Load Aws data
  4. Check data_updated_timestamp for provider once ingest complete
  5. Generate new AWS reports with no line items (really a nise thing at this point)
  6. Hit download for provider. See no new report files found
  7. Check data_updated_timestamp updated.

Notes:

This is something we noticed in stage because the polling time in stage is < 24 hours and our nise populator generates reports once a day. Meaning we hit this more often.

This is likely just a first of the month bug with Nise right now.

Release Notes

  • proposed release note
* [COST-5180](https://issues.redhat.com/browse/COST-5180) Fix inadvertently skipping polling after finding no new reports on previous day.

@lcouzens lcouzens requested review from a team as code owners July 3, 2024 13:46
@lcouzens lcouzens added the smoke-tests pr_check will build the image and run minimal required smokes label Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.1%. Comparing base (45d8e31) to head (150f305).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5205   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        373     373           
  Lines      31127   31129    +2     
  Branches    4571    4572    +1     
=====================================
+ Hits       29297   29301    +4     
+ Misses      1165    1162    -3     
- Partials     665     666    +1     

@lcouzens lcouzens enabled auto-merge (squash) July 17, 2024 08:31
@lcouzens lcouzens added hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix and removed smoke-tests pr_check will build the image and run minimal required smokes labels Jul 19, 2024
@lcouzens lcouzens merged commit 682edb8 into main Jul 19, 2024
10 of 11 checks passed
@lcouzens lcouzens deleted the update-data_updated_timestamp-when-no-new-reports branch July 19, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants