Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5228] log outside for loop #5202

Merged
merged 5 commits into from
Jul 3, 2024
Merged

[COST-5228] log outside for loop #5202

merged 5 commits into from
Jul 3, 2024

Conversation

djnakabaale
Copy link
Contributor

@djnakabaale djnakabaale commented Jul 2, 2024

Jira Ticket

COST-5228

Description

This change will move logging outside for loops to reduce unnecessary breadcrumbs

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Load test data
  4. See that everything loads fine

Release Notes

  • proposed release note
* [COST-5228](https://issues.redhat.com/browse/COST-5228) Move logging outside for loop

@djnakabaale djnakabaale self-assigned this Jul 2, 2024
@djnakabaale djnakabaale added the smoke-tests pr_check will build the image and run minimal required smokes label Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.1%. Comparing base (89feae0) to head (1df1040).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5202   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        376     376           
  Lines      31255   31256    +1     
  Branches    4602    4602           
=====================================
+ Hits       29420   29422    +2     
  Misses      1168    1168           
+ Partials     667     666    -1     

@djnakabaale djnakabaale marked this pull request as ready for review July 2, 2024 20:03
@djnakabaale djnakabaale requested review from a team as code owners July 2, 2024 20:03
@djnakabaale djnakabaale enabled auto-merge (squash) July 3, 2024 14:00
@djnakabaale djnakabaale merged commit bdbbfee into main Jul 3, 2024
11 checks passed
@djnakabaale djnakabaale deleted the log-outside-for-loop branch July 3, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
2 participants