Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[COST-5216] Delete filtering optimization" #5200

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

myersCody
Copy link
Contributor

@myersCody myersCody commented Jul 2, 2024

Reverts #5197

Does not work with minio yet

@myersCody myersCody requested review from a team as code owners July 2, 2024 13:37
@myersCody myersCody added the hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix label Jul 2, 2024
@myersCody
Copy link
Contributor Author

/retest

@myersCody myersCody enabled auto-merge (squash) July 2, 2024 13:39
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.2%. Comparing base (97ba98e) to head (6b0f3b1).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5200     +/-   ##
=======================================
- Coverage   94.2%   94.2%   -0.0%     
=======================================
  Files        376     376             
  Lines      31254   31252      -2     
  Branches    3734    3734             
=======================================
- Hits       29430   29425      -5     
- Misses      1160    1163      +3     
  Partials     664     664             

@myersCody myersCody merged commit 066faf6 into main Jul 2, 2024
11 checks passed
@myersCody myersCody deleted the revert-5197-COST-5216-head-object branch July 2, 2024 13:56
djnakabaale pushed a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
2 participants