[COST-5226] - Skip S3 delete (daily flow) if we have marked deletion complete. #5198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-5226
Description
This change will add an additional check inside get_or_clear_daily_s3_by_date to not only check if another worker has set the processing start date but also if the parquet files have been deleted.
The real change in this PR is really just this line
if not manifest_accessor.get_s3_parquet_cleared(manifest):
I also included a small change to use
get_s3_objects_not_matching_metadata
instead of having duplicate logic to maintain.Testing
Release Notes