Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5214] Remove directive to make the build work with docker #5196

Merged

Conversation

samdoran
Copy link
Contributor

Jira Ticket

COST-5214

Description

There is a podman bug that needs to be resolved which required adding this out of stage directive. Unfortunately that broke the image build for docker, which we use heavily.

This is a terrible hack until the bug in podman is resolved.

containers/podman#23046

Testing

  1. Checkout Branch
  2. make docker-build

Release Notes

  • proposed release note
* [COST-5214](https://issues.redhat.com/browse/COST-5214) Fix the container image for local development

There is a podman bug that needs to be resolved which required adding
this out of stage directive. Unfortunately that broke the image build
for docker, which we use heavily.

This is a terrible hack until the bug in podman is resolved.

containers/podman#23046
@samdoran samdoran requested review from a team as code owners June 28, 2024 22:20
@samdoran samdoran added the hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix label Jun 28, 2024
@samdoran
Copy link
Contributor Author

What's very confusing about this is that adding the global ARG TARGETARCH declaration fixed the build for podman, but it breaks it for docker.

As best I can tell, docker sets TARGETARCH automatically. By adding ARG TARGETARCH it sets the value to nothing, which is what breaks the docker build.

Changing the directive to ARG TARGETARCH=arm64 allows it work for both docker and podman, but hard cording the architecture defeats the purpose of using the variable in the first place.

Makefile Outdated Show resolved Hide resolved
maskarb
maskarb previously approved these changes Jul 1, 2024
@maskarb maskarb merged commit abd4261 into main Jul 1, 2024
11 checks passed
@maskarb maskarb deleted the COST-5078/COST-5214-multiarch-containerfile-fix-for-docker branch July 1, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix ok-to-skip-smokes
Projects
None yet
3 participants