[COST-5213] - fix S3 prepare #5194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcouzens
added
the
smoke-tests
|
/retest |
samdoran
reviewed
Jun 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5194 +/- ##
=====================================
Coverage 94.2% 94.2%
=====================================
Files 376 376
Lines 31257 31252 -5
Branches 3735 3734 -1
=====================================
- Hits 29435 29432 -3
+ Misses 1161 1160 -1
+ Partials 661 660 -1 |
myersCody
reviewed
Jun 28, 2024
cgoodfred
approved these changes
Jun 28, 2024
myersCody
approved these changes
Jun 28, 2024
djnakabaale
pushed a commit
that referenced
this pull request
Jul 9, 2024
* Switch default parquet flag to prevent iterating on all files in each worker when there is nothing to delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-5213
Description
This change will revert the default of
s3_parquet_clearedflag. Then during daily processing we should set this flag accordingly.The problem before is each worker was flipping this flag back and forth instead of holding a constant for all running workers. Meaning as we processed more files for a single provider this filtering/collection of files for deletion would take longer and longer while ultimately deleting nothing.
Testing
removed s3 files and marked manifest s3_parquet_clearedis only called once per month.Release Notes