Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flower as a dev dependency #5189

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Add flower as a dev dependency #5189

merged 3 commits into from
Jun 26, 2024

Conversation

samdoran
Copy link
Contributor

Description

Add flower as a dev dependency to provide bette visibly into celery tasks during development.

Testing

  1. Checkout Branch
  2. Run pipenv install --dev
  3. Run celery -A koku flower
  4. Open http://localhost:5555

Release Notes

  • proposed release note
* Add [flower](https://flower.readthedocs.io/en/latest/index.html) as a development dependency

@samdoran samdoran requested review from a team as code owners June 25, 2024 19:53
@samdoran samdoran added hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix and removed smokes-required labels Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.2%. Comparing base (c7eb09d) to head (1da3029).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5189   +/-   ##
=====================================
  Coverage   94.2%   94.2%           
=====================================
  Files        376     376           
  Lines      31230   31230           
  Branches    3725    3725           
=====================================
+ Hits       29411   29413    +2     
+ Misses      1160    1157    -3     
- Partials     659     660    +1     

Flower is installed with the dev dependencies but it is not run by default. To start Flower, run

```
celery -A koku flower
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

side note: it should be run inside koku/koku (or wherever the celery.py file is).

Copy link
Contributor

@bacciotti bacciotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, worked.

@samdoran samdoran enabled auto-merge (squash) June 26, 2024 13:46
@samdoran samdoran merged commit 011ec69 into main Jun 26, 2024
11 checks passed
@samdoran samdoran deleted the add-flower branch June 26, 2024 14:02
djnakabaale pushed a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
2 participants