-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-4981] reset local unleash #5148
Conversation
|
||
|
||
if __name__ == "__main__": | ||
wait_unleash_ready() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible this could be replaced by a health check in the compose file. The unleash service could benefit from adding a healthcheck for the db service as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would the healthcheck be for unleash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unleash
image only has busybox
, so something like this.
healthcheck:
test:
- "CMD"
- "wget"
- "-qO-"
- "http://localhost:4242/health"
That still needs some refinement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to leverage a healthcheck here. Even when adding one, the make command just moves on, healthy or not. The DB healthcheck is good though, so I added that. I'm just not sure we can do away with the wait_unleash_ready
from this script.
Jira Ticket
COST-4981
Description
Closes #5068
This change will:
cost-management.backend.schema-flag-template
andcost-management.backend.source-uuid-flag-template
.unleash
dir todev/containers/unleash
dev/scripts/setup_unleash.py
). This script also seeds the template flags.UNLEASH_ADMIN_TOKEN
UNLEASH_TOKEN
is scoped to thedevelopment
environmentUNLEASH_PAT
is the user PAT used to seed the db and can be used with any API calls wantedTesting
make docker-down delete db
make docker-up-db
http://localhost:4242/profile/personal-api-tokens
Release Notes