Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-9884 updated openapi.json - added description for ROS recomme… #5113

Closed

Conversation

PreetiW
Copy link

@PreetiW PreetiW commented May 17, 2024

Jira Ticket

RHINENG-9884

Description

updated openapi.json - added description for ROS recommendation API endpoint

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoint or launch shell
    1. You should see ...
  4. Do more things...

Release Notes

  • proposed release note

@PreetiW PreetiW requested review from a team as code owners May 17, 2024 09:32
@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@lcouzens
Copy link
Contributor

@PreetiW whats the exact intention here? To render a link in the description for the refs? I could be wrong but I'm not entirely sure if this will work.
image

@PreetiW
Copy link
Author

PreetiW commented Jun 11, 2024

@PreetiW whats the exact intention here? To render a link in the description for the refs? I could be wrong but I'm not entirely sure if this will work. image

Hello @lcouzens, thank you for providing review on the PR. My aim here is to provide information about the ROS OpenAPI Json file for the developers outside our team. Hence I added a description mentioning where the OpenAPI Json file is for the ref. Do let me know if you have any better suggestion to achieve the same so that anyone looking at the OpenAPI Json file understands to look at https://github.com/RedHatInsights/ros-ocp-backend/blob/main/openapi.json for ROS APIs. Let me know if you have any question around the same 🙌🏻

@lcouzens
Copy link
Contributor

@PreetiW did you manage to find an alternative solution for this, or should we close this for now?

@lcouzens
Copy link
Contributor

I'm going to close this for now. Feel free to reopen or create a new PR when you have something. 🙇

@lcouzens lcouzens closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants