-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add usage units fallback for OCP on GCP storage endpoint #4975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4975 +/- ##
=====================================
Coverage 94.1% 94.1%
=====================================
Files 375 375
Lines 31170 31170
Branches 3704 3704
=====================================
Hits 29327 29327
Misses 1176 1176
Partials 667 667 |
esebesto
added
the
gcp-smoke-tests
pr_check will build the image and run gcp + ocp on gcp smoke tests
label
Mar 15, 2024
/retest |
bacciotti
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
1 similar comment
/retest |
esebesto
removed
the
gcp-smoke-tests
pr_check will build the image and run gcp + ocp on gcp smoke tests
label
Apr 2, 2024
Closing this PR as it is not relevant anymore (it was a bugfix for GCP unit update, which was later reverted) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4392
Description
This PR attempts to fix missing usage units in OCP on GCP storage endpoint when we have no OCP on GCP storage data. The missing units are apparent in UI so it would be better to fix it.
Testing
http://localhost:8000/api/cost-management/v1/reports/openshift/infrastructures/gcp/storage/
http://localhost:8000/api/cost-management/v1/reports/openshift/infrastructures/gcp/storage/?limit=102