Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external reference for OpenShift recommendations #4859

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Jan 8, 2024

Description

Go back to using an external ref. We will update the broken tests to accommodate the external reference.

Related to #4799, #4845, #4857.

@samdoran samdoran requested review from a team as code owners January 8, 2024 16:27
@maskarb maskarb added the smoke-tests pr_check will build the image and run minimal required smokes label Jan 8, 2024
Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@samdoran samdoran enabled auto-merge (squash) January 8, 2024 17:51
@samdoran samdoran disabled auto-merge January 8, 2024 17:55
@samdoran samdoran enabled auto-merge (squash) January 8, 2024 17:55
@samdoran samdoran disabled auto-merge January 8, 2024 17:57
@samdoran samdoran enabled auto-merge (squash) January 8, 2024 18:10
@samdoran samdoran merged commit 62481c7 into main Jan 8, 2024
10 checks passed
@samdoran samdoran deleted the docs/ros-external-ref branch January 8, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants