Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4532] Rename field that contains the OpenShift project name #4843

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

samdoran
Copy link
Contributor

Jira Ticket

COST-4532

Description

Rename the field containing the OpenShift project name to project from project_name

Testing

tox -e py39 -- api.settings.test.cost_groups

curl -gsSL 'localhost:8000/api/cost-management/v1/settings/cost-groups/?filter[project]=open' | jello

@samdoran samdoran added the hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix label Dec 19, 2023
@samdoran samdoran requested review from a team as code owners December 19, 2023 22:56
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #4843 (42f849d) into main (e01b5ce) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4843   +/-   ##
=====================================
  Coverage   94.0%   94.0%           
=====================================
  Files        364     364           
  Lines      30210   30210           
  Branches    3599    3599           
=====================================
+ Hits       28390   28393    +3     
+ Misses      1161    1158    -3     
  Partials     659     659           

Copy link

sonarcloud bot commented Dec 19, 2023

@samdoran samdoran merged commit 4ec522a into main Dec 20, 2023
10 checks passed
@samdoran samdoran deleted the COST-3394/COST-4532-rename-project-field branch December 20, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants