Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TrinoStatementExecError #4842

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Improve TrinoStatementExecError #4842

merged 6 commits into from
Jan 5, 2024

Commits on Dec 20, 2023

  1. Improve TrinoStatementExecError 

    - Require parameters that are useful when handling this exception type
- Expose the underlying TrinoQueryError directly
- Use the __str__ method for formatting the error code
- Use implicit string concatenation
    @samdoran
    samdoran committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    b4e2deb View commit details
    Browse the repository at this point in the history

  2. Dedent raw SQL statements in tests for better legibility

    @samdoran
    samdoran committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    3e9d4b6 View commit details
    Browse the repository at this point in the history

  3. Update tests 

    - Don’t import the whole module
- Correct repr
- Increase coverage of trino_database.py
    @samdoran
    samdoran committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    e85efae View commit details
    Browse the repository at this point in the history

  4. Don’t dedent multi-line strings

    @samdoran
    samdoran committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    2681795 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Update coverage exclusions

    @samdoran
    samdoran committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    c27b088 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Merge branch 'main' into improve-trino-exception

    @samdoran
    samdoran committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    4c1f85c View commit details
    Browse the repository at this point in the history