[COST-4440] Warn when a partition already exists for OCP processing #4838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4838 +/- ##
=====================================
Coverage 94.0% 94.0%
=====================================
Files 364 364
Lines 30204 30210 +6
Branches 3598 3599 +1
=====================================
+ Hits 28383 28390 +7
Misses 1161 1161
+ Partials 660 659 -1 |
samdoran
force-pushed
the
COST-4440/trino-partition-already-exists
branch
2 times, most recently
from
a448c1c
to
cec8370
Compare
samdoran
added
the
smoke-tests
This appears to be a problem only with OCP processing and only when two workers are running the same workload practiaclly at the same exact time. This may indicate a problem with our worker caching not preventing simultaneous execution, or a problem with celery allowing duplicate tasks to run. We don’t have enough information to determine that currently. Since this is isolated to OCP processing, I fixed it only in the OPC processing instead of making changes to update_summary_tables, which would affect all provider types.
samdoran
force-pushed
the
COST-4440/trino-partition-already-exists
branch
from
cec8370
to
2911e6c
Compare
samdoran
force-pushed
the
COST-4440/trino-partition-already-exists
branch
from
8ac380d
to
a5d0d5c
Compare
We can Exception before raising TrinoStatementExecError, so it may not have the expected attributes.
samdoran
force-pushed
the
COST-4440/trino-partition-already-exists
branch
from
a5d0d5c
to
91850f7
Compare
cgoodfred
approved these changes
Dec 19, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4440
Description
Catch a Trino exception and log it.
This appears to be a problem only with OCP processing and only when two workers are running the same workload practiaclly at the same exact time. This may indicate a problem with our worker caching not preventing simultaneous execution, or a problem with celery allowing duplicate tasks to run. We don’t have enough information to determine that currently.
Since this is isolated to OCP processing, I fixed it only in the OCP processing instead of making changes to
update_summary_tables, which would affect all provider types.