-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-3814] Add Azure processing to subs flow #4754
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4754 +/- ##
=======================================
- Coverage 94.0% 94.0% -0.0%
=======================================
Files 364 364
Lines 30132 30204 +72
Branches 3589 3598 +9
=======================================
+ Hits 28312 28379 +67
- Misses 1160 1164 +4
- Partials 660 661 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job Corey!! I left you a few minor suggestions that we may need to handle. Otherwise it looks good! Well until Eva gets to work 🤣
client_secret = credentials.get("client_secret") | ||
_factory = AzureClientFactory(subscription_id, tenant_id, client_id, client_secret) | ||
compute_client = _factory.compute_client | ||
response = compute_client.virtual_machines.get( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure you already have this covered. But for my curiosity, does this client query need additional permissions exposed on the customer side? I assume it does since we only have something like storage blob and cost management reader roles right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there's an additional Reader
role that will need to be added. It will be called out in docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 👍🏾
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
Jira Ticket
COST-3814
Description
This change will add Azure processing to the subs flow. It extends the AWS processing to handle Azure sources. We are processing the same information as before with an additional tag option of
com_redhat_rhel_instance
to allow someone to add that tag instead of giving the additional Reader permission to the Azure scope.Example of a kafka message that would be sent:
Testing
com_redhat_rhel
tag on a VM. (reach out to Corey if you need credentials for a source that has this)Notes
The AWS smokes label was run to ensure no regression in the AWS Subs Processing flow since there are not yet smokes for the Azure flow.
Example from setting only
AWS
enabled in the environment to give us more control over where different providers process:...