Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COST-4101] tech debt remove ocp on gcp summarization by node. #4626

Merged
merged 12 commits into from
Sep 26, 2023
Merged

[COST-4101] tech debt remove ocp on gcp summarization by node. #4626

merged 12 commits into from
Sep 26, 2023

Conversation

myersCody
Copy link
Contributor

Jira Ticket

COST-4101

Description

This change will remove a code path that we no longer use. The original issue mentioned this would only be a stop gap solution: https://issues.redhat.com/browse/COST-2992

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoint or launch shell
    1. You should see ...
  4. Do more things...

Notes

...

@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #4626 (2a535eb) into main (dd4ba19) will decrease coverage by 0.3%.
Report is 753 commits behind head on main.
The diff coverage is 92.3%.

@@           Coverage Diff           @@
##            main   #4626     +/-   ##
=======================================
- Coverage   94.1%   93.8%   -0.3%     
=======================================
  Files        375     367      -8     
  Lines      32469   30227   -2242     
  Branches    3547    3574     +27     
=======================================
- Hits       30546   28346   -2200     
- Misses      1215    1220      +5     
+ Partials     708     661     -47

@myersCody myersCody changed the title COST-4101: tech debut remove ocp on gcp summarization by node. [COST-4101] tech debut remove ocp on gcp summarization by node. Aug 10, 2023
@myersCody myersCody added the smoke-tests pr_check will build the image and run minimal required smokes label Aug 11, 2023
@myersCody myersCody changed the title [COST-4101] tech debut remove ocp on gcp summarization by node. [COST-4101] tech debt remove ocp on gcp summarization by node. Aug 11, 2023
@myersCody myersCody marked this pull request as ready for review August 14, 2023 14:01
@myersCody myersCody requested review from a team as code owners August 14, 2023 14:01
@myersCody myersCody self-assigned this Aug 22, 2023
lcouzens
lcouzens approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@lcouzens lcouzens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great clean up PR! 🙇 Thanks Cody.

@myersCody myersCody enabled auto-merge (squash) September 19, 2023 18:07
@myersCody
Copy link
Contributor Author

/retest

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@myersCody myersCody merged commit 7d787f0 into main Sep 26, 2023
11 checks passed
@myersCody myersCody deleted the COST-4101-ocp-on-gcp-node-summarization branch September 26, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcouzens lcouzens lcouzens approved these changes

Assignees

@myersCody myersCody

Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@myersCody @lcouzens