Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COST-4377] Remove deprecated tag models. #4605

Merged
merged 23 commits into from
Nov 2, 2023
Merged

[COST-4377] Remove deprecated tag models. #4605

merged 23 commits into from
Nov 2, 2023

Conversation

myersCody
Copy link
Contributor

@myersCody myersCody commented Jul 29, 2023 •
edited by lcouzens
Loading

Jira Ticket

COST-4377

Description

This change will ...

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoint or launch shell
    1. You should see ...
  4. Do more things...

Notes

...

@myersCody myersCody requested review from a team as code owners July 29, 2023 20:14
@myersCody myersCody added the on hold This issue is on hold pending an update label Jul 29, 2023
@myersCody
Copy link
Contributor Author

waiting for new settings to launch.

@codecov
Copy link

codecov bot commented Jul 29, 2023 •
edited
Loading

Codecov Report

Merging #4605 (03c180b) into main (791e82e) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main   #4605     +/-   ##
=======================================
- Coverage   93.7%   93.7%   -0.0%     
=======================================
  Files        367     367             
  Lines      30526   30488     -38     
  Branches    3616    3616             
=======================================
- Hits       28610   28572     -38     
  Misses      1239    1239             
  Partials     677     677

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@myersCody myersCody marked this pull request as draft August 14, 2023 14:54
@myersCody myersCody self-assigned this Aug 22, 2023
@myersCody myersCody added smoke-tests pr_check will build the image and run minimal required smokes and removed on hold This issue is on hold pending an update labels Sep 6, 2023
@myersCody myersCody marked this pull request as ready for review September 6, 2023 19:46
lcouzens
lcouzens requested changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@lcouzens lcouzens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good for the most part, just need to get that little migration typo fix I think. Thanks for the hard work Cody! 🙇

koku/reporting/migrations/0305_pvc.py Outdated Show resolved Hide resolved
lcouzens
lcouzens previously approved these changes Sep 19, 2023
View reviewed changes
@lcouzens lcouzens changed the title [COST-3976] Remove deprecated tag models. [COST-4377] Remove deprecated tag models. Nov 1, 2023
@myersCody myersCody enabled auto-merge (squash) November 2, 2023 17:23
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@myersCody myersCody merged commit 21f9dbc into main Nov 2, 2023
11 checks passed
@myersCody myersCody deleted the COST-3976-deprecated-tables branch November 2, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcouzens lcouzens lcouzens approved these changes

Assignees

@myersCody myersCody

Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@myersCody @lcouzens