Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5076] upgrade to python 3.11 #4444

Merged
merged 16 commits into from
Jul 2, 2024
Merged

[COST-5076] upgrade to python 3.11 #4444

merged 16 commits into from
Jul 2, 2024

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Jun 9, 2023

Jira Ticket

COST-5076

Description

This change will upgrade to python 3.11.

@maskarb maskarb added the hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix label Jun 9, 2023
Dockerfile Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (0507abb) to head (549c20d).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4444     +/-   ##
=======================================
- Coverage   94.2%   94.1%   -0.0%     
=======================================
  Files        376     376             
  Lines      31247   31255      +8     
  Branches    3733    4602    +869     
=======================================
- Hits       29425   29422      -3     
- Misses      1161    1167      +6     
- Partials     661     666      +5     

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@maskarb maskarb added smoke-tests pr_check will build the image and run minimal required smokes and removed hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix labels Aug 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@maskarb maskarb removed the smoke-tests pr_check will build the image and run minimal required smokes label Nov 15, 2023
@maskarb maskarb added smoke-tests pr_check will build the image and run minimal required smokes labels May 29, 2024
@maskarb
Copy link
Member Author

maskarb commented May 29, 2024

/retest

1 similar comment
@maskarb
Copy link
Member Author

maskarb commented May 30, 2024

/retest

@maskarb maskarb changed the title upgrade to python 3.11 [COST-5076] upgrade to python 3.11 May 30, 2024
@maskarb maskarb marked this pull request as ready for review May 30, 2024 18:51
@maskarb maskarb requested review from a team as code owners May 30, 2024 18:51
@samdoran
Copy link
Contributor

samdoran commented Jun 3, 2024

We can also update the pre-commit hooks:

diff --git .pre-commit-config.yaml .pre-commit-config.yaml
index 828eec398..29d46f47c 100644
--- .pre-commit-config.yaml
+++ .pre-commit-config.yaml
@@ -3,16 +3,16 @@ default_language_version:
 
 repos:
   - repo: https://github.com/asottile/reorder_python_imports
-    rev: v3.9.0
+    rev: v3.13.0
     hooks:
       - id: reorder-python-imports
-        args: [--py3-plus, --application-directories, "koku"]
+        args: [--py311-plus, --application-directories, "koku"]
 
   - repo: https://github.com/asottile/pyupgrade
-    rev: v3.3.1
+    rev: v3.15.2
     hooks:
       - id: pyupgrade
-        args: [--py36-plus]
+        args: [--py311-plus]
 
   - repo: https://github.com/ambv/black
     rev: 22.12.0

cgoodfred
cgoodfred previously approved these changes Jul 2, 2024
@maskarb maskarb merged commit 89feae0 into main Jul 2, 2024
11 checks passed
@maskarb maskarb deleted the python311 branch July 2, 2024 18:53
djnakabaale pushed a commit that referenced this pull request Jul 9, 2024
* upgrade to python 3.11

* pipfile update

* add gcc-c++ compiler

Co-authored-by: Sam Doran <[email protected]>

* update test

* replace gcc with gcc-c++

---------

Co-authored-by: Sam Doran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
4 participants