Correct type hints

project-koku · Dec 5, 2023 · 4ba2a60 · 4ba2a60
1 parent 4e1532c
commit 4ba2a60
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/koku/api/settings/cost_groups/query_handler.py b/koku/api/settings/cost_groups/query_handler.py
@@ -22,19 +22,21 @@
 LOG = logging.getLogger(__name__)
 
 
-def _remove_default_projects(projects: list[dict[str:str]]) -> list[dict[str:str]]:
+def _remove_default_projects(projects: list[dict[str, str]]) -> list[dict[str, str]]:
     try:
         _remove_default_projects.system_default_namespaces  # type: ignore[attr-defined]
     except AttributeError:
         # Cache the system default namespcases
-        _remove_default_projects.system_default_namespaces = OpenshiftCostCategoryNamespace.objects.filter(
+        _remove_default_projects.system_default_namespaces = OpenshiftCostCategoryNamespace.objects.filter(  # type: ignore[attr-defined]  # noqa: E501
             system_default=True
-        ).values_list("namespace", flat=True)
+        ).values_list(
+            "namespace", flat=True
+        )
 
     exact_matches = {
-        project for project in _remove_default_projects.system_default_namespaces if not project.endswith("%")
+        project for project in _remove_default_projects.system_default_namespaces if not project.endswith("%")  # type: ignore[attr-defined]  # noqa: E501
     }
-    prefix_matches = set(_remove_default_projects.system_default_namespaces).difference(exact_matches)
+    prefix_matches = set(_remove_default_projects.system_default_namespaces).difference(exact_matches)  # type: ignore[attr-defined]  # noqa: E501
 
     scrubbed_projects = []
     for request in projects:
@@ -49,7 +51,7 @@ def _remove_default_projects(projects: list[dict[str:str]]) -> list[dict[str:str
     return scrubbed_projects
 
 
-def put_openshift_namespaces(projects: list[dict[str:str]]) -> list[dict[str:str]]:
+def put_openshift_namespaces(projects: list[dict[str, str]]) -> list[dict[str, str]]:
     projects = _remove_default_projects(projects)
 
     # Build mapping of cost groups to cost category IDs in order to easiy get
@@ -74,7 +76,7 @@ def put_openshift_namespaces(projects: list[dict[str:str]]) -> list[dict[str:str
     return projects
 
 
-def delete_openshift_namespaces(projects: list[dict[str:str]]) -> list[dict[str:str]]:
+def delete_openshift_namespaces(projects: list[dict[str, str]]) -> list[dict[str, str]]:
     projects = _remove_default_projects(projects)
     projects_to_delete = [item["project_name"] for item in projects]
     deleted_count, _ = (
@@ -113,12 +115,12 @@ def __init__(self, parameters: QueryParameters) -> None:
         self._set_filters_or_exclusion()
 
     @property
-    def order_by(self) -> str:
+    def order_by(self) -> list[str]:
         order_by_params = self.parameters._parameters.get("order_by")
         if not order_by_params:
             return self._default_order_by
 
-        result = []
+        result: list[str] = []
         for key, order in order_by_params.items():
             if order == "desc":
                 result.insert(0, f"-{key}")

diff --git a/koku/api/settings/cost_groups/view.py b/koku/api/settings/cost_groups/view.py
@@ -88,7 +88,7 @@ def delete(self, request: Request) -> Response:
 
         return Response(status=status.HTTP_204_NO_CONTENT)
 
-    def _summarize_current_month(self, schema_name: str, projects: list[dict[str:str]]) -> list[str]:
+    def _summarize_current_month(self, schema_name: str, projects: list[dict[str, str]]) -> list[str]:
         """Resummarize OCP data for the current month."""
         projects_to_summarize = [proj["project_name"] for proj in projects]
         ocp_queue = OCP_QUEUE