Merge pull request #3071 from dlabrecq/bugs2

Adjusted query params for for "All projects" modal
project-koku · Apr 11, 2023 · fba77a1 · fba77a1
2 parents e0c8e04 + 2280fe6
commit fba77a1
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/routes/views/details/components/summary/summaryModalContent.tsx b/src/routes/views/details/components/summary/summaryModalContent.tsx
@@ -121,9 +121,8 @@ const mapStateToProps = createMapStateToProps<SummaryModalContentOwnProps, Summa
         ...(queryFromRoute &&
           queryFromRoute.filter &&
           queryFromRoute.filter.account && { [`${logicalAndPrefix}account`]: queryFromRoute.filter.account }),
-        ...(groupBy && { [groupBy]: groupByValue }), // group bys must appear in filter to show costs by regions, accounts, etc
-        // Omit filters associated with the current group_by -- see https://issues.redhat.com/browse/COST-1131 and https://issues.redhat.com/browse/COST-3642
-        ...(groupBy && groupByValue !== '*' && { [groupBy]: undefined }),
+        // Related to https://issues.redhat.com/browse/COST-1131 and https://issues.redhat.com/browse/COST-3642
+        ...(groupBy && groupByValue !== '*' && { [groupBy]: groupByValue }), // group bys must appear in filter to show costs by region, account, etc
         // Workaround for https://issues.redhat.com/browse/COST-1189
         ...(queryState &&
           queryState.filter_by &&