Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify controller test cases #170

Merged
merged 15 commits into from
May 10, 2023
Merged

simplify controller test cases #170

merged 15 commits into from
May 10, 2023

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Mar 7, 2023

  • update the controller test suite so the result of one test does not affect the result of another
  • each test can now be run individually
  • tests should be more robust to future code changes
  • should be easier to add new tests in the future

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #170 (f4fe2b3) into main (be0268b) will decrease coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   88.78%   88.27%   -0.52%     
==========================================
  Files          11       11              
  Lines        2328     2328              
==========================================
- Hits         2067     2055      -12     
- Misses        186      196      +10     
- Partials       75       77       +2     
Flag Coverage Δ
unittests 88.27% <ø> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be0268b...f4fe2b3. Read the comment docs.

@maskarb maskarb changed the title slight reorg and simplification simplify controller test cases May 9, 2023
@maskarb maskarb self-assigned this May 9, 2023
@maskarb maskarb requested a review from a team May 9, 2023 19:07
@maskarb maskarb marked this pull request as draft May 9, 2023 19:12
@maskarb maskarb marked this pull request as ready for review May 9, 2023 20:00
@maskarb maskarb merged commit 26f6aea into main May 10, 2023
@maskarb maskarb deleted the move-stuff branch May 10, 2023 13:19
maskarb added a commit that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants