[Silabs] Refactor Wifi eventing structure to be align with C++ standards #36366
+171
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36366: Size comparison from c05110f to dc4471b Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Nov 5, 2024
| @@ -18,55 +18,48 @@ | |||
|
|
|||
| #include <app/icd/server/ICDServerConfig.h> | |||
| #include <cmsis_os2.h> | |||
| #include <lib/support/BitFlags.h> | |||
There was a problem hiding this comment.
Not for this pr, but shouldn't we create an interface class for all this?
There was a problem hiding this comment.
Yes; most of this is Wiseconnect (9116 and 917) specifique but is included by the wf200 for some reason
Co-authored-by: Junior Martinez <[email protected]>
|
PR #36366: Size comparison from c05110f to b9f1624 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36366: Size comparison from c05110f to b5747ee Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR refactors the Wi-Fi event data structure and usage.
The PR has no functionnal changes.
Tests
Commissioning and CI