[Darwin] add API to get public key without leaks (with fixes) #36340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
kiel-apple
changed the title
|
PR #36340: Size comparison from b0cc28a to d5bfe8d Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: Boris Zbarsky <[email protected]>
…onal method calls
it's a test; this is the best we can do with an optional protocol method
remove comment - not this method's job to worry about other implementation's potential side-effects
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #36340: Size comparison from f3a9fe9 to 47e264a Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
check compatibility in CI before going back and removing
|
PR #36340: Size comparison from f3a9fe9 to 8dbbcaa Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36340: Size comparison from f3a9fe9 to d328eaf Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36340: Size comparison from 50ad31c to fbbd06a Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36340: Size comparison from 62a4a97 to fdbd53c Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Nov 5, 2024
examples/darwin-framework-tool/commands/common/CHIPToolKeypair.mm
Outdated
Show resolved
Hide resolved
| SecKeyRef originalKeyRef = [testKeys publicKey]; | ||
| SecKeyRef originalKeyRef; | ||
| if ([testKeys respondsToSelector:@selector(copyPublicKey)]) { | ||
| originalKeyRef = [testKeys copyPublicKey]; |
There was a problem hiding this comment.
This also looks like a leak.
There was a problem hiding this comment.
(added CFAutorelease(originalKeyRef); below - it has been a while, scrutiny welcome)
There was a problem hiding this comment.
(specifically: is manual creation of NSAutoreleasePool or use of @autoreleasepool merited here?
There was a problem hiding this comment.
You also need to nil check CFAutorelease, please just use [object autorelease] per our chat
There was a problem hiding this comment.
(Otherwise you have a crash here potentially)
woody-apple
reviewed
Nov 5, 2024
| @@ -277,7 +293,7 @@ - (void)testGenerateOperationalCertNoIntermediateWithValidityPeriod | |||
|
|
|||
| __auto_type * operationalCert = [MTRCertificates createOperationalCertificate:rootKeys | |||
| signingCertificate:rootCert | |||
| operationalPublicKey:operationalKeys.publicKey | |||
| operationalPublicKey:operationalPublicKey | |||
There was a problem hiding this comment.
Why not copy autorelease this? Makes for much easier code...
|
PR #36340: Size comparison from 62a4a97 to a761b1c Increases above 0.2%:
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverted because mergify landed it with failing checks...?
CFAutoreleaseon CoreFoundation typed public key copiescopyPublicKeyforMTRTestKeys; add TODO note about optional method callscopyPublicKeycallscopyPublicKeyinMTRTestKeys